Skip to content

Conversation

@rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Dec 24, 2025

Summary

This forces the SelectPrincipal dropdown to display search results if the dropdown has been closed for any reason.

Fixes #16246

Occurred changes and/or fixed issues

  • Display search results if the dropdown is closed

Technical notes summary

There are situations where the dropdown can be closed while a user might want to search for a principal, see #16246 for one those cases. This forces the dropdown to reopen when results exist.

Alternatively, we can always force it to open when a search term is applied.

I attempted to prevent the dropdown from closing on click, but there were too many edge cases where the it could still actually close. I found this initial solution to be overly complex and have opted for allowing the dropdown to close and forcing it to open again instead.

Areas or cases that should be tested

Follow the repro steps in the associated issue. Ensure that the results are displayed after typing. Ensure that the results can be selected via mouse and keyboard.

Areas which could experience regressions

There's a possibility that keyboard navigation and selection could be affected. I think this risk is small.

Screenshot/Video

NA

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked in 2.14-head and we don't have this component covered in terms of keyboard nav, so there are no regressions in that front. I would say LGTM

@rak-phillip rak-phillip merged commit 005c24e into rancher:master Jan 5, 2026
83 of 94 checks passed
@rak-phillip rak-phillip deleted the bugfix/16246-open-search branch January 5, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug on project members input search/usage

2 participants